https://bugs.documentfoundation.org/show_bug.cgi?id=160783
V Stuart Foote <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from V Stuart Foote <[email protected]> --- (In reply to Julien Nabet from comment #11) > I had submitted https://gerrit.libreoffice.org/c/core/+/166736 but your idea > seems better so I abandoned my patch/ No, your patch of skiahelper.cxx is the way to go. I don't think we should integrate the gpuinfo.org project stuff, its just out there to get a better handle on the driver strings and device IDs we need. > However, I suppose using this requires more work than a simple patch > (dealing with gbuild, make the app work for all OSes, removing parts in LO, > adding other ones which call the external code, etc.) Think we just need to decide if we want to test the uint32_t returned by prop.driverVersion, or the suggested Vendor masking to render to string as in comment 6. > I can't help here => uncc myself. With so much effort as you've invested in the Vulkan denylist handling, you deserve a say in how it could be refactored--if at all. =-=-= another sidebar, regards the bitwise mask for extracting the Vulkan driverVersion for Intel GPUs. So I guess we're doing the correct thing with them? On a Win11 laptop with Intel Iris Plus graphics that needed a driver update. Ran the Vulkan Caps viewer, and vulkaninfo.exe, and compared to the skia.log (of our handling of the Vulkan driver conversion For the 27.20.100.8853 Intel driver *Vulkan HW Capability 1.2.151 and 0.402.661 (and in DB as 100.8853) *vulkaninfo.exe Device Properties and Extensions: ================================= GPU0: VkPhysicalDeviceProperties: --------------------------- apiVersion = 4202647 (1.2.151) driverVersion = 1647253 (0x192295) vendorID = 0x8086 deviceID = 0x8a52 deviceType = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU deviceName = Intel(R) Iris(R) Plus Graphics skia.log RenderMethod: vulkan Vendor: 0x8086 Device: 0x8a52 API: 1.2.151 Driver: 0.402.661 DeviceType: integrated DeviceName: Intel(R) Iris(R) Plus Graphics Denylisted: no =-=-=-= For the 31.0.101.2115 Intel driver *Vulkan HW Capability 1.3.215 and 0.404.2115 (and in DB as 101.2115) *vulkaninfo.exe GPU0: VkPhysicalDeviceProperties: --------------------------- apiVersion = 4206807 (1.3.215) driverVersion = 1656899 (0x194843) vendorID = 0x8086 deviceID = 0x8a52 deviceType = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU deviceName = Intel(R) Iris(R) Plus Graphics pipelineCacheUUID = 7232703e-7731-4532-7a3f-79317e357c03 skia.log RenderMethod: vulkan Vendor: 0x8086 Device: 0x8a52 API: 1.3.215 Driver: 0.404.2115 DeviceType: integrated DeviceName: Intel(R) Iris(R) Plus Graphics Denylisted: noion). -- You are receiving this mail because: You are the assignee for the bug.
