https://bugs.documentfoundation.org/show_bug.cgi?id=51357

--- Comment #14 from Devansh Varshney <[email protected]> ---
(In reply to Devansh Varshney from comment #13)
> Just a quick question the 'miscDiagonalWipe' is not present in the
> sd/xml/effects.xml 
> 
> but it's present int the filter/source/svg/presentation_engine.js
> 
>   'miscDiagonalWipe'  : MISCDIAGONALWIPE_TRANSITION,
> var MISCDIAGONALWIPE_TRANSITION     = 24; // 7
> 
> 
> same for the    
> 
>  'pushWipe'          : PUSHWIPE_TRANSITION,
> 
> 
> 
> but, as given in point 2 they are present in the -
> 
> TransitionType.idl and TransitionSubType.idl
> 
> So, I just want to clarify that do I have add same in the effects.xml ?

One more question -

I am adding the support for the triangleWipe -

In the offapi/com/sun/star/animations/TransitionSubType.idl there are already
variables which are assigned the value as described on the w3.org -

"triangleWipe"  "up" (103) [default], "right" (104), "down" (105), "left" (106) 


    const short FADEFROMCOLOR = 103;
    const short FADEOVERCOLOR = 104;

    // Most of those below are non-standard, not in SMIL 2.0
    const short THREEBLADE = 105;
    const short EIGHTBLADE = 106;
    const short ONEBLADE = 107;
    const short ACROSS = 108;
    const short TOPLEFTVERTICAL = 109; // Is in SMIL
    const short COMBHORIZONTAL = 110;
    const short COMBVERTICAL = 111;
    const short IN = 112; // Not actually a subtype, and apparently unused
    const short OUT = 113; // Ditto
    const short ROTATEIN = 114;
    const short ROTATEOUT = 115;
    const short FROMTOPLEFT = 116;
    const short FROMTOPRIGHT = 117;
    const short FROMBOTTOMLEFT = 118;
    const short FROMBOTTOMRIGHT = 119;

    // Below are for the triangleWipe
    const short TRIANGLEWIPE_UP = 103;
    const short TRIANGLEWIPE_RIGHT = 104;
    const short TRIANGLEWIPE_DOWN = 105;
    const short TRIANGLEWIPE_LEFT = 106; 



So should I do this ?- 

    // Below are for the triangleWipe
    const short TRIANGLEWIPE_UP = 120;    //103
    const short TRIANGLEWIPE_RIGHT = 121; //104
    const short TRIANGLEWIPE_DOWN = 122;  //105
    const short TRIANGLEWIPE_LEFT = 123;  //106

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to