https://bugs.documentfoundation.org/show_bug.cgi?id=145538
--- Comment #34 from Buovjaga <[email protected]> --- (In reply to Devansh Varshney from comment #33) > should I do something this in this > libreoffice/basic/source/classes/image.cxx file at line 429- > > for( size_t i = 0; i < mvStringOffsets.size(); i++ ) > { > sal_uInt16 nOff = static_cast<sal_uInt16>(mvStringOffsets[ i ]); > OString > aStr(OUStringToOString(std::u16string_view(pStrings.get() + nOff), > eCharSet)); > memcpy( pByteStrings.get() + nOff, aStr.getStr(), > (aStr.getLength() + 1) * sizeof( char ) ); > } > > to something like - > > for (const sal_uInt32& offset : mvStringOffsets) { > sal_uInt16 nOff = static_cast<sal_uInt16>(offset); > OString aStr(OUStringToOString(std::u16string_view(pStrings.get() + > nOff), eCharSet)); > memcpy(pByteStrings.get() + nOff, aStr.getStr(), (aStr.getLength() + 1) > * sizeof(char)); > } Please discuss such in a Gerrit patch you send. It is usually the best place. -- You are receiving this mail because: You are the assignee for the bug.
