On 21/05/2018 08:33, Zhong Li wrote: > Not convenient if using numerals to set MFE mode. It is ambiguous > and misleading (e.g: user may misunderstand setting mfmode to 1 is to > enable MFE but actually it is to disable MFE, and set it to be 5 or above is > meaningless). > > V2: remove the manual option since it is not supported now. > > Signed-off-by: Zhong Li <[email protected]> > --- > libavcodec/qsvenc_h264.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c > index ae00ff8..2ecdb10 100644 > --- a/libavcodec/qsvenc_h264.c > +++ b/libavcodec/qsvenc_h264.c > @@ -94,7 +94,9 @@ static const AVOption options[] = { > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE}, > > #if QSV_HAVE_MF > - { "mfmode", "Multi-Frame Mode", OFFSET(qsv.mfmode), AV_OPT_TYPE_INT, { > .i64 = MFX_MF_AUTO }, 0, INT_MAX, VE }, > + { "mfmode", "Multi-Frame Mode", OFFSET(qsv.mfmode), AV_OPT_TYPE_INT, { > .i64 = MFX_MF_AUTO }, MFX_MF_DEFAULT, MFX_MF_AUTO, VE, "mfmode"}, > + { "off" , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_MF_DISABLED }, > INT_MIN, INT_MAX, VE, "mfmode" }, > + { "auto" , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_MF_AUTO }, > INT_MIN, INT_MAX, VE, "mfmode" }, > #endif > > { NULL }, >
Sounds fine to me, the previous iteration was on hold since Maxym wanted to test it. I guess this time it should work as intended on every current mfx release :) lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
