On Mon, Mar 12, 2018 at 11:27 AM, Diego Biurrun <[email protected]> wrote: >> --- a/libavcodec/avcodec.h >> +++ b/libavcodec/avcodec.h >> @@ -2551,6 +2551,10 @@ typedef struct AVCodecContext { >> #define FF_PROFILE_HEVC_MAIN_STILL_PICTURE 3 >> #define FF_PROFILE_HEVC_REXT 4 >> >> +#define FF_PROFILE_AV1_0 0 >> +#define FF_PROFILE_AV1_1 1 >> +#define FF_PROFILE_AV1_2 2 > > I think it's a mistake to add more FF_-prefixed stuff into avcodec.h > and I don't see why these defines have to be in a public header. They > are only used in libaomenc.c, I don't see a reason to place them > outside of that file. >
All codec profiles are listed right there with a FF prefix, its used by the user to set avctx->profile (or check the profile from a decoder), so the symbols make sense to have public. - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
