On Mon, Feb 19, 2018 at 07:15:16PM +0100, Diego Biurrun wrote: > If configure fails before config.fate is generated, the report file misses > some values and gets discarded by the FATE server. In these cases, make an > effort to fill in sensible values and provide "unknown" as fallback value. > --- > > Made some changes as suggested by Janne on IRC, i.e. try to provide some > info instead of calling all fields "unknown".
22:11 <@jannau> DonDiego: I don't think the best effort guess for all fields is a good idea. 22:13 <@jannau> those fields are usually somewhat sanitized through configure and compiler 22:13 <@jannau> and we use it to filter the fate results 22:16 <@jannau> those values are also not really unknown. they are missing since configure failed for some reason 22:18 <@jannau> so 'failed' is IMO a better value in this case 22:21 <@jannau> the best effor guesses do not contain any additional information compared to the configure command so it's probably better to just use 'failed' for all runs which fail to write a config.fate 22:22 * jannau probably should have written an email Yeah, I've thought about the same things. Updated patch according to your suggestion coming up. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
