On Sat, Feb 10, 2018 at 11:07 AM, Luca Barbato <[email protected]> wrote:
> On 09/02/2018 22:56, Sean McGovern wrote:
>>
>> From: Michael Niedermayer <[email protected]>
>>
>> Bug-Id: 1100
>> Bug-Id: ffmpeg/Ticket2531
>> Cc: [email protected]
>> ---
>>   libavcodec/vc1dec.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
>> index 8902110..5005a21 100644
>> --- a/libavcodec/vc1dec.c
>> +++ b/libavcodec/vc1dec.c
>> @@ -652,7 +652,7 @@ static int vc1_decode_frame(AVCodecContext *avctx,
>> void *data,
>>                                     buf_size3 << 3);
>>                       /* assuming that the field marker is at the exact
>> middle,
>>                          hope it's correct */
>> -                    slices[n_slices].mby_start = s->mb_height >> 1;
>> +                    slices[n_slices].mby_start = s->mb_height + 1 >> 1;
>>                       n_slices1 = n_slices - 1; // index of the last slice
>> of the first field
>>                       n_slices++;
>>                       break;
>> @@ -700,7 +700,7 @@ static int vc1_decode_frame(AVCodecContext *avctx,
>> void *data,
>>                   buf_size3 = vc1_unescape_buffer(divider + 4, buf +
>> buf_size - divider - 4, slices[n_slices].buf);
>>                   init_get_bits(&slices[n_slices].gb,
>> slices[n_slices].buf,
>>                                 buf_size3 << 3);
>> -                slices[n_slices].mby_start = s->mb_height >> 1;
>> +                slices[n_slices].mby_start = s->mb_height + 1 >> 1;
>>                   n_slices1 = n_slices - 1;
>>                   n_slices++;
>>               }
>>
>
> Looks strange, isn't it (s->mb_height + 1) >> 1 ?
>

+ has a higher precedence then the shift, so the braces are unnecessary.

- Hendrik
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to