On Thu, 7 Dec 2017 13:25:10 +0100 Luca Barbato <[email protected]> wrote:
> On 07/12/2017 08:26, Zhong Li wrote: > > Signed-off-by: Zhong Li <[email protected]> > > --- > > libavcodec/qsvdec_other.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_other.c > > index 1ba803b..cc5f205 100644 > > --- a/libavcodec/qsvdec_other.c > > +++ b/libavcodec/qsvdec_other.c > > @@ -60,6 +60,11 @@ static av_cold int qsv_decode_close(AVCodecContext > > *avctx) > > { > > QSVOtherContext *s = avctx->priv_data; > > > > +#if CONFIG_VP8_QSV_DECODER > > + if (avctx->codec_id == AV_CODEC_ID_VP8) > > + av_freep(&s->qsv.load_plugins); > > +#endif > > + > > ff_qsv_decode_close(&s->qsv); > > > > qsv_clear_buffers(s); > > > > Are you sure? qsv.load_plugins should be an avoption and thus get > automatically freed once you close the codec... Check the other uses of this field, and you'll see the horrible hack VP8 support is doing. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
