On Mon, Oct 23, 2017 at 11:55:10AM +0200, wm4 wrote: > On Sun, 22 Oct 2017 02:15:07 +0200 > Diego Biurrun <[email protected]> wrote: > > On Thu, Oct 19, 2017 at 05:25:17PM +0200, wm4 wrote: > > > lavc: external hardware frame pool initialization > > > > > > --- a/libavcodec/decode.c > > > +++ b/libavcodec/decode.c > > > @@ -669,6 +669,88 @@ static AVHWAccel *find_hwaccel(enum AVCodecID > > > codec_id, > > > +int ff_decode_get_hw_frames_ctx(AVCodecContext *avctx, > > > + enum AVHWDeviceType dev_type) > > > +{ > > > + ret = avcodec_get_hw_frames_parameters(avctx, > > > + avctx->hw_device_ctx, > > > + avctx->hwaccel->pix_fmt, > > > + avctx->hw_frames_ctx); > > > > This generates a very suspicious warning: > > > > libavcodec/decode.c: In function ‘ff_decode_get_hw_frames_ctx’: > > libavcodec/decode.c:701:44: warning: passing argument 4 of > > avcodec_get_hw_frames_parameters’ from incompatible pointer type > > [-Wincompatible-pointer-types] > > avctx->hw_frames_ctx); > > ^~~~~ > > In file included from libavcodec/decode.c:34:0: > > libavcodec/avcodec.h:4094:5: note: expected ‘AVBufferRef ** {aka struct > > AVBufferRef **}’ but argument is of type ‘AVBufferRef * {aka struct > > AVBufferRef *}’ > > int avcodec_get_hw_frames_parameters(AVCodecContext *avctx, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Probably forgot to update and test this part. Possibly crashes in > hw_device_ctx mode.
I'm tempted to think that part of the reason you overlooked this warning is the fact that that file produces deprecation warning spam. Please review my patch to address those deprecation warnings. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
