On 10/17/2017 10:22 PM, Diego Biurrun wrote:
> A private fallback roundf() implementation is not worth the trouble
> for a fringe feature like libxvid encoding.
Removing libxvid support from every MSVC <= 2012 build (and maybe also
other compilers) to save six lines in an internal header seems a bit
unjustified...
And i don't know if you're aware that the scene of xvid rips is
(inexplicably) still alive.
> ---
> configure | 2 +-
> libavutil/libm.h | 7 -------
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/configure b/configure
> index 2008083617..2477086799 100755
> --- a/configure
> +++ b/configure
> @@ -2388,7 +2388,7 @@ libx262_encoder_deps="libx262"
> libx264_encoder_deps="libx264"
> libx265_encoder_deps="libx265"
> libxavs_encoder_deps="libxavs"
> -libxvid_encoder_deps="libxvid mkstemp"
> +libxvid_encoder_deps="libxvid mkstemp roundf"
Wouldn't this keep libxvid enabled (thus libavcodec linking to it)?
>
> # demuxers / muxers
> ac3_demuxer_select="ac3_parser"
> diff --git a/libavutil/libm.h b/libavutil/libm.h
> index d6c2cf8623..478207b6c8 100644
> --- a/libavutil/libm.h
> +++ b/libavutil/libm.h
> @@ -154,13 +154,6 @@ static av_always_inline av_const double round(double x)
> }
> #endif /* HAVE_ROUND */
>
> -#if !HAVE_ROUNDF
> -static av_always_inline av_const float roundf(float x)
> -{
> - return (x > 0) ? floor(x + 0.5) : ceil(x - 0.5);
> -}
> -#endif /* HAVE_ROUNDF */
> -
> #if !HAVE_TRUNC
> static av_always_inline av_const double trunc(double x)
> {
>
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
