On 24/06/17 16:48, Diego Biurrun wrote:
> On Sat, Jun 24, 2017 at 11:56:07AM -0300, James Almer wrote:
>> On 6/23/2017 8:39 PM, Mark Thompson wrote:
>>> --- a/libavcodec/h264.h
>>> +++ b/libavcodec/h264.h
>>> @@ -44,4 +44,49 @@ enum {
>>> +
>>> +enum {
>>
>> enum seems like a weird choice for this to be honest. Same with the
>> following patch.
>>
>> What's wrong with using #define?
>
> Why would you want to use #defines when you can use an enum? What's wrong
> with type safety? :)
Well, when you need the value at preprocess-time to make some sort of
conditional compilation decision. I don't think that's wanted here, though:
hence enum.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
