Quoting Diego Biurrun (2016-11-18 10:46:05)
> ---
> libavformat/ape.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/ape.c b/libavformat/ape.c
> index 80e3372..d917815 100644
> --- a/libavformat/ape.c
> +++ b/libavformat/ape.c
> @@ -94,9 +94,9 @@ static int ape_probe(AVProbeData * p)
> return 0;
> }
>
> +#ifdef DEBUG
> static void ape_dumpinfo(AVFormatContext * s, APEContext * ape_ctx)
> {
> -#ifdef DEBUG
> int i;
>
> av_log(s, AV_LOG_DEBUG, "Descriptor Block:\n\n");
> @@ -154,8 +154,10 @@ static void ape_dumpinfo(AVFormatContext * s, APEContext
> * ape_ctx)
> av_log(s, AV_LOG_DEBUG, "junklength = %"PRIu32"\n",
> ape_ctx->junklength);
> av_log(s, AV_LOG_DEBUG, "firstframe = %"PRIu32"\n",
> ape_ctx->firstframe);
> av_log(s, AV_LOG_DEBUG, "totalsamples = %"PRIu32"\n",
> ape_ctx->totalsamples);
> -#endif
> }
> +#else
> +#define ape_dumpinfo(s, ape_ctx)
> +#endif
>
> static int ape_read_header(AVFormatContext * s)
> {
> --
> 2.1.4
This is incredibly silly IMO. Unused function parameters are very common
and are NOT a problem (which is why they are not enabled by default).
Shuffling perfectly valid code around just to appease some specific
compiler with some specific settings is just useless noise in history.
--
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
