On 2016-10-18 13:55:53 +0200, Diego Biurrun wrote:
> This can be useful to filter out noise in known-broken scenarios like
> miscompilation by legacy compilers and similar.
> ---
>
> Now adds a "fate-" prefix to the test name on its own.
>
> configure | 4 ++++
> tests/Makefile | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/configure b/configure
> index 745b5b7..bec4772 100755
> --- a/configure
> +++ b/configure
> @@ -347,6 +347,8 @@ Developer options (useful when working on Libav itself):
> --random-seed=VALUE seed value for --enable/disable-random
> --disable-valgrind-backtrace do not print a backtrace under Valgrind
> (only applies to --disable-optimizations builds)
> + --skip-tests=TESTS whitespace-separated list of FATE tests to skip
> + (without "fate-" prefix in the name)
I'd prefer something more neutral like --ignore-tests so that it's
possible to change the behavior from skipping tests to actually run the
tests and ignore the results or notice when the test changes its result
to passing. I want to change the behavior later and it shouldn't
require changes to fate configs.
> NOTE: Object files are built at the place where configure is
> launched.
> EOF
> @@ -1808,6 +1810,7 @@ CMDLINE_SET="
> pkg_config_flags
> random_seed
> samples
> + skip_tests
> sysinclude
> sysroot
> target_exec
> @@ -5313,6 +5316,7 @@ SLIB_INSTALL_EXTRA_LIB=${SLIB_INSTALL_EXTRA_LIB}
> SLIB_INSTALL_EXTRA_SHLIB=${SLIB_INSTALL_EXTRA_SHLIB}
> VERSION_SCRIPT_POSTPROCESS_CMD=${VERSION_SCRIPT_POSTPROCESS_CMD}
> SAMPLES:=${samples:-\$(LIBAV_SAMPLES)}
> +SKIP_TESTS=$skip_tests
> EOF
>
> get_version(){
> diff --git a/tests/Makefile b/tests/Makefile
> index 36a3a72..c49116c 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -142,6 +142,8 @@ endif
>
> FATE_UTILS = base64 tiny_psnr
>
> +FATE := $(filter-out $(addprefix fate-,$(SKIP_TESTS)),$(FATE))
> +
> fate: $(FATE)
I think
@@ ...
-fate: $(FATE)
+fate: $(filter-out $(addprefix fate-,$(SKIP_TESTS)),$(FATE))
would work better. You can still run the tests individually and if you
skip one h264 test make fate-h264 wouldn't complain about a missing
rule. It would also not hide the skipped tests from make fate-list
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
