Quoting Janne Grunau (2016-07-08 09:47:29) > Fixes a regression in ca2f19b9cc3 with some mov/mp4 files. The files have > several NAL units in the supposed single NAL unit after the size field. > Annex B start code prefixes are used to separate them. The first NAL unit > is correctly parsed but the buffer does not point to the next size field. > Instead semi random data (it seems to be the rbsp_stop_one_bit and the > start code prefix) is then parsed as length and will exceed the > remaining length of the buffer. > > Patch based on the code in h264's decode_nal_units() and a similar > patch by Hendrik Leppkes in FFmpeg (a9bb4cf87d1). > > Bug-Id: ffmpeg/trac5529 > Reported-By: Vittorio Giovara
A thousand curses on whoever is responsible for such files. I guess the patch is ok, but since the code is now a lot less simple than I'd like, it'd be nice to have a comment there about why it looks the way it does. Also, a FATE test would be quite appropriate. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
