Quoting Martin Storsjö (2015-09-23 11:18:15) > This allows changing the log level on the fly at any time. > > This causes all messages to actually be formatted within OpenH264 > (OpenH264 only snprintf formats the log messages that actually > are going to be printed, just like av_log), even ones that will > be discarded by the libav log level. This could be considered a > small extra performance penalty, but it is only about 6 lines of > logging per encoded frame, so it shouldn't matter significantly, > and makes the code shorter and simpler. > --- > I can squash this into the first patch if you prefer. IMO this > makes the code more readable, by dedicating fewer lines of the > file on the log redirecting.
Squashing looks preferable to me, it's a bit silly to add all those lines just to remove many of them immediately. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
