On 17/04/15 16:08, Andreas Cadhalpun wrote:
> On 17.04.2015 02:01, Luca Barbato wrote:
>> On 16/04/15 20:19, Andreas Cadhalpun wrote:
>>> On 16.04.2015 19:41, Claudio Freire wrote:
>>>> It should be if band->thr > 0.0f, all divisions by zero return
>>>> something that casts into an ~1:
>>
>> is band->thr = 0.0f a valid value?
> 
> Come to think of it, that's probably invalid.
> It can happen if coeffs[g].ath is not positive.

ath() returns easily Inf and negative values...

> Attached patch errors out in this case.
> 
>> band->energy can be 0?
> 
> Yes, it's set to 0.0f in calc_thr_3gpp if enough coefs are 0.

and in that case the threshold? (that is calculated as a fraction of the
energy at least in one place).

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to