On Fri, Apr 10, 2015 at 12:17 PM, Diego Biurrun <[email protected]> wrote: > On Fri, Apr 10, 2015 at 11:58:13AM +0200, Vittorio Giovara wrote: >> On Fri, Apr 10, 2015 at 11:33 AM, Vittorio Giovara >> <[email protected]> wrote: >> > On Thu, Apr 9, 2015 at 6:30 PM, Diego Biurrun <[email protected]> wrote: >> >> On Thu, Apr 09, 2015 at 06:12:30PM +0200, Vittorio Giovara wrote: >> >>> --- /dev/null >> >>> +++ b/libavcodec/hq_hqa.c >> >>> @@ -0,0 +1,370 @@ >> >>> + /* HQ defines dimensions and number of slices, so walking order is >> >>> too; >> >>> + * HQA has no size constraint and features a fixed number of slices, >> >>> + * thus there is a separate scheme for it. */ >> >> >> >> I don't understand what you are saying about "walking order". >> > >> > Locally changed to "HQ defines dimensions and number of slices, and >> > thus walking order, HQA has no size constraint and a fixed number of >> > slices, so it needs a separate scheme for it." >> >> Actually >> "HQ defines dimensions and number of slices, and thus slice traversal >> order, HQA has no size constraint and a fixed number of slices, so it >> needs a separate scheme for it." > > While we're working on your English composition skill: note that the > sentence is awfully long and would be more readable split in two: > > "HQ defines dimensions and number of slices, and thus slice traversal > order. HQA has no size constraint and a fixed number of slices, so it > needs a separate scheme for it."
Is there any other non-linguistic comment to the set? Thanks -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
