On Wed, Apr 8, 2015 at 5:10 PM, Diego Biurrun <[email protected]> wrote:
> +static const uint32_t *pAllowable = &els_exp_tab[ELS_JOTS_PER_BYTE * 3];

why is this a static var? if i understand the code correctly it could
be a local variable in ff_els_decode_bit() no?

> +void ff_els_decoder_uninit(ElsUnsignedRung *rung)
> +{
> +    av_free(rung->rem_rung_list);
> +}

might as well use av_freep

> +
> +#define RUNG_SPACE (64 * sizeof(ElsRungNode))

nit: I'd group this with the other defines on the top


I have no further comments.
-- 
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to