Quoting Vittorio Giovara (2015-04-02 14:10:05)
> On Tue, Mar 31, 2015 at 4:31 PM, Diego Biurrun <[email protected]> wrote:
> > From: Kostya Shishkov <[email protected]>
> >
> > ELS and ePIC decoder courtesy of Maxim Poliakovski,
> > cleanup and integration by Diego Biurrun.
> >
> > Signed-off-by: Diego Biurrun <[email protected]>
> > ---
> >
> > Now states Go2Meeting support prominently in the file header,
> > as requested by Kostya.
> >
> >  Changelog            |   1 +
> >  doc/general.texi     |   2 +
> >  libavcodec/Makefile  |   2 +-
> >  libavcodec/elsdec.c  | 411 ++++++++++++++++++++++++++++
> >  libavcodec/elsdec.h  |  60 ++++
> >  libavcodec/g2meet.c  | 757 
> > +++++++++++++++++++++++++++++++++++++++++++++++++--
> >  libavcodec/version.h |   2 +-
> >  7 files changed, 1209 insertions(+), 26 deletions(-)
> >  create mode 100644 libavcodec/elsdec.c
> >  create mode 100644 libavcodec/elsdec.h
> > --- /dev/null
> > +++ b/libavcodec/elsdec.c
> > +    { -1,  -72, 169, 145 },
> > +    { -6,   -5, 168,  49 },
> > +    {  0, -108, 171, 171 },
> > +    {  0, -108, 172, 172 },
> > +    { -6,   -5, 173, 173 }
> 
> nit: comma at the end
> 
> > +};
> > +
> > +static int els_exp_tab[ELS_JOTS_PER_BYTE * 4 + 1];
> > +static const int *pAllowable = &els_exp_tab[ELS_JOTS_PER_BYTE * 3];
> 
> Is there no way to avoid the static variables here? Maybe the could be
> members of ElsDecCtx.

Seems to me it should be rather simple to make this table constant
instead of generated at runtime.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to