On 13/01/15 16:00, Vittorio Giovara wrote: > On Tue, Jan 13, 2015 at 3:37 PM, Martin Storsjö <[email protected]> wrote: >> Did you open it before calling avformat_find_stream_info? That's the only >> case when things could wrong. Or is it called somewhere else - can you >> explain exactly what you did to make things crash? > > I don't have the application with me any more, but this is probably > what happened, opening the codec before avformat_find_stream_info(). > >> Perhaps, but this is not an issue with avformat_new_stream at all - it is an >> issue with avformat_find_stream_info only. For users that don't use that >> function, adding this comment for avformat_new_stream is highly misleading >> and confusing. > > I see your point, so it's better to leave avformat_new_stream alone. > > Maybe would it be worth to add a line or two to > avformat_find_stream_info? Perhaps just a "@ref avcodec_open2()" or > another helpful comment would do. >
for avstream info add a @note This function call avcodec_open2 on the stream codec context, make sure you do not allocate the stream codec contexts before using this function. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
