On Wed, Dec 3, 2014 at 11:04 AM, Luca Barbato <[email protected]> wrote: > On 24/11/14 18:05, Vittorio Giovara wrote: >> >> - return -2; >> + return AVERROR_INVALIDDATA; > > > This look fishy. -2 has any special meaning in this code?
I change that code. Looking at mpeg12 family there is not a single comparison against -2. In mpegvideo there is only SLICE_END define but I am not sure it applie here. mpeg_decode_postinit is used in a single place which always return if negative. Actually looking at the code, there is ff_set_dimensions that checks exactly that, would it be fine if I dropped this check entirely? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
