On Thu, Jul 17, 2014 at 6:51 PM, Luca Barbato <[email protected]> wrote:
> Certain servers accept only PUT as valid method.
> ---
> libavformat/http.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 948930a..5aa985d 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -43,6 +43,11 @@
> #define BUFFER_SIZE MAX_URL_SIZE
> #define MAX_REDIRECTS 8
>
> +enum {
> + HTTP_POST,
> + HTTP_PUT
> +};
> +
> typedef struct {
> const AVClass *class;
> URLContext *hd;
> @@ -85,6 +90,7 @@ typedef struct {
> #endif
> AVDictionary *chained_options;
> int send_expect_100;
> + char *write_method;
Shouldn't this be const?
> } HTTPContext;
>
> #define OFFSET(x) offsetof(HTTPContext, x)
> @@ -110,6 +116,7 @@ static const AVOption options[] = {
> {"location", "The actual location of the data received", OFFSET(location),
> AV_OPT_TYPE_STRING, { 0 }, 0, 0, D|E },
> {"offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, {.i64 =
> 0}, 0, INT64_MAX, D },
> {"end_offset", "try to limit the request to bytes preceding this offset",
> OFFSET(end_off), AV_OPT_TYPE_INT64, {.i64 = 0}, 0, INT64_MAX, D },
> +{"write_method", "Method to write to the remote server",
> OFFSET(write_method), AV_OPT_TYPE_STRING, { .str = "POST" }, 0, 0, E, },
> {NULL}
> };
> #define HTTP_CLASS(flavor)\
> @@ -555,7 +562,12 @@ static int http_connect(URLContext *h, const char *path,
> const char *local_path,
> s->chunked_post = 0;
> }
>
> - method = post ? "POST" : "GET";
> + if (post) {
> + method = s->write_method;
> + } else {
> + method = "GET";
> + }
> +
I think ok, you can drop the curly braces here if you feel like it.
--
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
