On Sat, Jul 05, 2014 at 12:28:18PM -0700, Timothy Gu wrote:
> On Jul 5, 2014 12:02 PM, "Nidhi Makhijani" <[email protected]> wrote:
> > --- a/libavformat/cdg.c
> > +++ b/libavformat/cdg.c
> > @@ -42,9 +42,10 @@ static int read_header(AVFormatContext *s)
> >
> >      ret = avio_size(s->pb);
> 
> > -    if (ret > 0)
> > -        vst->duration = (ret * vst->time_base.den) / (CDG_PACKET_SIZE *
> 300);
> > +    if (ret < 0)
> > +        return AVERROR_INVALIDDATA;
> 
> return ret;
> 
> Also, you need a special case for ret == 0. Originally, if ret == 0 no
> error is reported and it's silently ignored. But I think it warrants an
> AVERROR_INVALIDDATA too.

Why is the 0 case a problem?

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to