On Tue, May 20, 2014 at 08:40:13PM +0200, Hendrik Leppkes wrote:
> On Tue, May 20, 2014 at 7:28 PM, Diego Biurrun <[email protected]> wrote:
> > On Fri, May 09, 2014 at 01:54:18PM +0200, Hendrik Leppkes wrote:
> >> This fixes build failures on older mingw chains (before 2012).
> >> ---
> >> configure | 13 ++++++++++++-
> >> 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > I'm not convinced this is worth the trouble for supporting obsolete
> > platforms. AFAIK MinGW users update their build environments regularly.
> > So it seems to me this 2 year old platform is already obsolete and
> > moving into non-existence. Would you disagree?
>
> It broke one fate station on ffmpeg, so I figured I might send the
> patch here as well.
> I don't particularly care myself if this is checked, since I consider
> older headers broken (which they are, they contain broken macros)
I'm tempted to skip applying this patch then, if you don't mind.
Thanks for sending it anyway.
> >> @@ -4016,6 +4017,16 @@ disabled bzlib || check_lib2 bzlib.h
> >> BZ2_bzlibVersion -lbz2 || disable bzlib
> >> +enabled dxva2api_h &&
> >> + check_cc <<EOF && enable dxva2api_cobj
> >> +#define _WIN32_WINNT 0x0600
> >> +#define COBJMACROS
> >> +#include <windows.h>
> >> +#include <d3d9.h>
> >> +#include <dxva2api.h>
> >> +int main(void) { IDirectXVideoDecoder *o = NULL;
> >> IDirectXVideoDecoder_Release(o); return 0; }
> >
> > IDirectXVideoDecoder_Release(NULL); ?
>
> Since IDirectXVideoDecoder_Release is a macro, you actually need a
> typed variable for this to work, just NULL doesn't work.
> (IDirectXVideoDecoder *)NULL might work, but that seems no better.
I just asked out of curiosity.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
