On Thu, May 08, 2014 at 03:15:11PM +0200, Luca Barbato wrote:
> --- a/Makefile
> +++ b/Makefile
> @@ -76,6 +76,7 @@ $(foreach prog,$(AVBASENAMES),$(eval OBJS-$(prog) +=
> cmdutils.o))
> OBJS-avconv += avconv_opt.o avconv_filter.o
> OBJS-avconv-$(HAVE_VDPAU_X11) += avconv_vdpau.o
> OBJS-avconv-$(HAVE_DXVA2_LIB) += avconv_dxva2.o
> +OBJS-avconv-$(CONFIG_VDA) += avconv_vda.o
order
> --- /dev/null
> +++ b/avconv_vda.c
> @@ -0,0 +1,134 @@
> +
> +#include "libavcodec/avcodec.h"
> +#include "libavcodec/vda.h"
> +#include "libavutil/imgutils.h"
canonical order
> + switch (pixel_format) {
> + case kCVPixelFormatType_420YpCbCr8Planar: vda->tmp_frame->format =
> AV_PIX_FMT_YUV420P; break;
> + case kCVPixelFormatType_422YpCbCr8: vda->tmp_frame->format =
> AV_PIX_FMT_UYVY422; break;
> + default:
> + av_log(NULL, AV_LOG_ERROR,
> + "Unsupported pixel format: %u\n", pixel_format);
> + return AVERROR(ENOSYS);
I suggest breaking the case lines.
> + if (CVPixelBufferIsPlanar(pixbuf)) {
> +
> + planes = CVPixelBufferGetPlaneCount(pixbuf);
Drop the empty line.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
