On Fri, 14 Mar 2014 05:42:20 -0700, Diego Biurrun <[email protected]> wrote:
> There is no point in populating NuvContext with another DSPContext.
> ---
>  libavcodec/nuv.c    | 12 ++++--------
>  libavcodec/rtjpeg.c | 11 ++++-------
>  libavcodec/rtjpeg.h |  5 ++---
>  3 files changed, 10 insertions(+), 18 deletions(-)
> 

IMO this makes the code more fragile.

dsp is now stored in rtjpeg, but relies on external code initializing it. In
case someone were to reuse this code, they'd have to remember to initialize it
too.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to