On 08/22/2013 08:54 AM, John Stebbins wrote: > The element was only being written when the value == 1. But the default > value of this element is 1, so this has no useful effect. This element > needs to be written when the value == 0. > --- > libavformat/matroskaenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 610787d..825e92c 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matroskaenc.c > @@ -587,7 +587,9 @@ static int mkv_write_tracks(AVFormatContext *s) > tag = av_dict_get(st->metadata, "language", NULL, 0); > put_ebml_string(pb, MATROSKA_ID_TRACKLANGUAGE, tag ? > tag->value:"und"); > > - if (st->disposition) > + // The default value for TRACKFLAGDEFAULT is 1, so add element > + // if we need to clear it. > + if (!(st->disposition & AV_DISPOSITION_DEFAULT)) > put_ebml_uint(pb, MATROSKA_ID_TRACKFLAGDEFAULT, > !!(st->disposition & AV_DISPOSITION_DEFAULT)); > > // look for a codec ID string specific to mkv to use, ping
-- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
