On 08/01/2012 07:14 AM, Daniel Kang wrote: > On Wed, Aug 1, 2012 at 1:03 AM, Daniel Kang <[email protected]> wrote: > >> On Wed, Aug 1, 2012 at 12:57 AM, Loren Merritt >> <[email protected]>wrote: >> >>> libavcodec/x86/dsputil_mmx_avg_template.c:58:1: warning: >>> `put_pixels4_l2_3dnow' defined but not used >>> libavcodec/x86/dsputil_mmx_avg_template.c:229:1: warning: >>> `avg_pixels4_l2_3dnow' defined but not used >>> libavcodec/x86/dsputil_mmx_avg_template.c:875:1: warning: >>> `avg_pixels4_3dnow' defined but not used >>> >> >> Those errors are fairly difficult to fix. Whoever wrote the original >> inlined assembly made it very hard to disable only certain functions at >> specific CPU types. Which would you prefer, a hack-ish workaround or to >> wait until I port the rest over to yasm? >> > > I'm thinking something along the lines of: > > diff --git a/libavcodec/x86/dsputil_mmx.c b/libavcodec/x86/dsputil_mmx.c > index 47d99f9..126a0b9 100644 > --- a/libavcodec/x86/dsputil_mmx.c > +++ b/libavcodec/x86/dsputil_mmx.c > @@ -198,12 +198,14 @@ DECLARE_ALIGNED(16, const double, ff_pd_2)[2] = { > 2.0, 2.0 }; > #define DEF(x) x ## _3dnow > #define PAVGB "pavgusb" > #define OP_AVG PAVGB > +#define IS_3DNOW
Not nice but not horrible. I'd live with it for a short time. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
