On 07/25/2012 07:25 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Jul 23, 2012 at 7:12 AM, Ronald S. Bultje <[email protected]> wrote: >> On Sun, Jul 22, 2012 at 2:38 PM, Ronald S. Bultje <[email protected]> wrote: >>> From: "Ronald S. Bultje" <[email protected]> >>> >>> Mixing yasm and inline asm is a bad idea, since if either yasm or inline >>> asm is not supported by your toolchain, all of the asm stops working. >>> Thus, better to use either one or the other alone. >>> --- >>> libavcodec/x86/vp3dsp.asm | 120 >>> +++++++++++++++++++++++++++++---------------- >>> 1 file changed, 79 insertions(+), 41 deletions(-) >> >> Ping. > > Jason LGTM'ed this over the weekend on IRC, I'll push this if there's > no further comments.
Seems ok, you might change don't to do not and drop the "." but those are nits. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
