On Mon, 23 Jul 2012, Derek Buitenhuis wrote:

On 23/07/2012 11:47 AM, Diego Biurrun wrote:
---
 configure                |    1 -
 doc/general.texi         |    1 -
 doc/protocols.texi       |    4 --
 libavformat/Makefile     |    1 -
 libavformat/allformats.c |    1 -
 libavformat/gopher.c     |  125 ----------------------------------------------
 6 files changed, 0 insertions(+), 133 deletions(-)
 delete mode 100644 libavformat/gopher.c

Looks OK. I'm sort of amused we supported gopher in the first place.

inb4 someone wants to keep support...

I don't have much opinion either way. Each time I've done refactoring that touches all network protocols, this one has been left untouched since I don't have too much of a test environment for it off-hand. I'm surprised to see that this code was added as late as 2009 though - that to me sounds like someone actually could be using it still. Keeping it around haven't held me back much when doing network code refactoring though, so I doubt we gain all that much by dropping it.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to