On Tue, Jul 3, 2012 at 4:30 PM, Kostya Shishkov <[email protected]> wrote: > On Tue, Jul 03, 2012 at 04:27:48PM +0200, Jordi Ortiz wrote: >> Without this patch "Unknown packet type received" message is shown and could >> lead to confusion >> --- >> libavformat/rtmpproto.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c >> index b48274b..d96510c 100644 >> --- a/libavformat/rtmpproto.c >> +++ b/libavformat/rtmpproto.c >> @@ -959,6 +959,12 @@ static int rtmp_parse_result(URLContext *s, RTMPContext >> *rt, RTMPPacket *pkt) >> return ret; >> } >> break; >> + case RTMP_PT_VIDEO: >> + av_log(s, AV_LOG_DEBUG, "Video\n"); >> + break; >> + case RTMP_PT_AUDIO: >> + av_log(s, AV_LOG_DEBUG, "Audio\n"); >> + break; >> default: >> av_log(s, AV_LOG_VERBOSE, "Unknown packet type received 0x%02X\n", >> pkt->type); >> break; >> -- > > LGTM, maybe Diego wants to reformulate log message a bit though.
mmh... I think instead of displaying debug messages when audio or video packets are received, you should, maybe, only add a comment which explains that these packets are parsed in get_packet(). -- Best regards, Samuel Pitoiset. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
