On Wed, May 23, 2012 at 01:51:53PM -0700, Dave Yeo wrote: > On 05/22/12 12:09 pm, Diego Biurrun wrote: > >Justin's patch that I just pushed fixes that issue, but the following > >remains: > > > >libavcodec/x86/h264_idct.asm:613: error: (call_internal:3) `%ifdef' expects > >macro identifiers > > > >A few dozen identical ones with different line numbers follow. > >Can somebody shine a light on this one? > > > >The original error message that my patch addresses is > > > >x86inc.asm:100: error: unknown 'cpu' type > > That error is still there with nasm 2.10. Reimar fixed it like with > the attached. > > --- a/libavutil/x86/x86inc.asm > +++ b/libavutil/x86/x86inc.asm > @@ -97,7 +97,9 @@ > > ; Always use long nops (reduces 0x90 spam in disassembly on x86_32) > +%ifdef __YASM_VER__ > CPU amdnop > +%endif
This patch is not enough. While it fixes the unknown cpu type, many errors of the following kind remain: libavcodec/x86/ac3dsp.asm:70: error: symbol `eaxm' undefined I'm testing with nasm 2.10.1, which is the latest version. Does anybody have ideas how to fix this? Otherwise the state of disrepair that nasm has been in for a long while begs the question if we really should keep pretending that we support it. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
