On Thu, Sep 08, 2011 at 02:55:15PM +0200, Stefano Sabatini wrote:
> On date Thursday 2011-09-08 14:31:41 +0200, Diego Biurrun encoded:
> > ---
> > libavutil/fifo.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavutil/fifo.c b/libavutil/fifo.c
> > index 5774d33..75a0439 100644
> > --- a/libavutil/fifo.c
> > +++ b/libavutil/fifo.c
> > @@ -145,8 +145,7 @@ int main(void)
> > /* peek at FIFO */
> > n = av_fifo_size(fifo)/sizeof(int);
> > for (i = -n+1; i < n; i++) {
> > - int *v = (int *)av_fifo_peek2(fifo, i*sizeof(int));
> > - printf("%d: %d\n", i, *v);
> > + printf("%d: %d\n", i, *av_fifo_peek2(fifo, i * sizeof(int)));
>
> This one should be safer:
>
> printf("%d: %d\n", i, *((int *)av_fifo_peek2(fifo, i*sizeof(int))));
>
> that is you cast from (void *) -> (int *), and *then* dereference.
This is not any prettier, so patch dropped. Thanks for the review.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
