On Thu, Sep 08, 2011 at 03:19:49PM +0300, aviad rozenhek wrote: > On Thu, Sep 8, 2011 at 14:49, Diego Biurrun <[email protected]> wrote: > > > On Thu, Sep 08, 2011 at 12:58:26PM +0300, [email protected] wrote: > > > > > > --- a/libavformat/mpegts.c > > > +++ b/libavformat/mpegts.c > > > @@ -1413,10 +1413,10 @@ static int handle_packets(MpegTSContext *ts, int > > nb_packets) > > > for (i = 0; i < NB_PID_MAX; i++) { > > > if (ts->pids[i]) { > > > if (ts->pids[i]->type == MPEGTS_PES) { > > > - PESContext *pes = ts->pids[i]->u.pes_filter.opaque; > > > - av_freep(&pes->buffer); > > > - pes->data_index = 0; > > > - pes->state = MPEGTS_SKIP; /* skip until pes header */ > > > + PESContext *pes = ts->pids[i]->u.pes_filter.opaque; > > > + av_freep(&pes->buffer); > > > + pes->data_index = 0; > > > + pes->state = MPEGTS_SKIP; /* skip until pes header */ > > > > I'd suggest squashing this patch into 1/3. > > > I thought it was standard procedure to do whitespace changes like reindent > in separate patches?
In Libav we are less strict about such things. It's basically a tradeoff between cluttering up the diff with whitespace changes or cluttering up the log with cosmetic commits. For small blocks I think the consensus is that they are not worth the extra commit clutter. I would think that this is such a case. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
