Diego Biurrun <[email protected]> writes:
> ---
Bad commit message. You should describe the change, not one of its
side-effects. Until you come up with a better description, this is
rejected.
> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> index ca5839f..30321a5 100644
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -651,7 +651,8 @@ OBJS-$(!CONFIG_SMALL) += inverse.o
>
> -include $(SUBDIR)$(ARCH)/Makefile
>
> -SKIPHEADERS = %_tablegen.h
> +SKIPHEADERS += %_tablegen.h aac_tablegen_decl.h \
> + fft-internal.h
> SKIPHEADERS-$(CONFIG_DXVA2) += dxva2.h dxva2_internal.h
> SKIPHEADERS-$(CONFIG_LIBDIRAC) += libdirac.h
> SKIPHEADERS-$(CONFIG_LIBSCHROEDINGER) += libschroedinger.h
Probably OK.
> diff --git a/libavcodec/mathops.h b/libavcodec/mathops.h
> index d74bc1e..98c9acf 100644
> --- a/libavcodec/mathops.h
> +++ b/libavcodec/mathops.h
> @@ -23,6 +23,7 @@
> #define AVCODEC_MATHOPS_H
>
> #include "libavutil/common.h"
> +#include "config.h"
>
> #if ARCH_ARM
> # include "arm/mathops.h"
OK
> diff --git a/libavcodec/mpc.h b/libavcodec/mpc.h
> index eea4b6d..51fd72a 100644
> --- a/libavcodec/mpc.h
> +++ b/libavcodec/mpc.h
> @@ -29,13 +29,15 @@
> #ifndef AVCODEC_MPC_H
> #define AVCODEC_MPC_H
>
> +#include <stdint.h>
> +
> #include "libavutil/lfg.h"
> #include "avcodec.h"
> #include "get_bits.h"
> #include "dsputil.h"
> #include "mpegaudio.h"
> +#include "mpegaudiodsp.h"
>
> -#include "mpcdata.h"
>
> #define BANDS 32
> #define SAMPLES_PER_BAND 36
This mixes several changes that might be better to split.
> diff --git a/libavcodec/mpegaudiodectab.h b/libavcodec/mpegaudiodectab.h
> index 041d186..1221657 100644
> --- a/libavcodec/mpegaudiodectab.h
> +++ b/libavcodec/mpegaudiodectab.h
> @@ -27,7 +27,9 @@
> #ifndef AVCODEC_MPEGAUDIODECTAB_H
> #define AVCODEC_MPEGAUDIODECTAB_H
>
> +#include <stddef.h>
> #include <stdint.h>
> +
> #include "mpegaudio.h"
>
> /*******************************************************/
Unrelated cosmetic change, stddef.h addition OK.
> diff --git a/libavcodec/put_bits.h b/libavcodec/put_bits.h
> index c426540..3849e6d 100644
> --- a/libavcodec/put_bits.h
> +++ b/libavcodec/put_bits.h
> @@ -34,6 +34,7 @@
> #include "libavutil/intreadwrite.h"
> #include "libavutil/log.h"
> #include "mathops.h"
> +#include "config.h"
>
> //#define ALT_BITSTREAM_WRITER
> //#define ALIGNED_BITSTREAM_WRITER
OK
> diff --git a/libavcodec/tableprint.h b/libavcodec/tableprint.h
> index ddf2635..de355fc 100644
> --- a/libavcodec/tableprint.h
> +++ b/libavcodec/tableprint.h
> @@ -26,8 +26,6 @@
> #include <inttypes.h>
> #include <stdio.h>
>
> -#include "libavutil/common.h"
> -
> #define WRITE_1D_FUNC_ARGV(type, linebrk, fmtstr, ...)\
> void write_##type##_array(const type *data, int len)\
> {\
OK
> diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
> index 38b736e..f80eb26 100644
> --- a/libavcodec/x86/Makefile
> +++ b/libavcodec/x86/Makefile
> @@ -57,3 +57,4 @@ OBJS-$(HAVE_MMX) += x86/dnxhd_mmx.o
> \
> x86/mpegvideo_mmx.o \
> x86/simple_idct_mmx.o \
>
> +SKIPHEADERS = x86/vp56_arith.h
SKIPHEADERS += $(ARCH)/vp56_arith.h in libavcodec/Makefile would cover
non-x86 as well.
> diff --git a/libavformat/network.h b/libavformat/network.h
> index db8466c..80d094a 100644
> --- a/libavformat/network.h
> +++ b/libavformat/network.h
> @@ -21,7 +21,10 @@
> #ifndef AVFORMAT_NETWORK_H
> #define AVFORMAT_NETWORK_H
>
> +#include <errno.h>
> +
> #include "config.h"
> +#include "libavutil/error.h"
> #include "os_support.h"
>
> #if HAVE_WINSOCK2_H
Probably OK.
--
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
