On Thu, 26 May 2011 09:29:18 -0700, Alex Converse <[email protected]> wrote: > On Thu, May 26, 2011 at 1:02 AM, Anton Khirnov <[email protected]> wrote: > > > > On Wed, 25 May 2011 18:00:03 -0700, Alex Converse <[email protected]> > > wrote: > >> --- > >> libavformat/id3v2.c | 7 ++++++- > >> 1 files changed, 6 insertions(+), 1 deletions(-) > >> > >> diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c > >> index 948261a..06ae6f8 100644 > >> --- a/libavformat/id3v2.c > >> +++ b/libavformat/id3v2.c > >> @@ -237,7 +237,7 @@ static void ff_id3v2_parse(AVFormatContext *s, int > >> len, uint8_t version, uint8_t > >> tag[3] = 0; > >> tlen = avio_rb24(s->pb); > >> } > >> - if (tlen < 0 || tlen > len - taghdrlen) { > >> + if (tlen <= 0 || tlen > len - taghdrlen) { > > > > This doesn't look related to what the patch is supposed to do. > > > > malloc 0 can return NULL. If we fail on a NULL malloc return then we > should avoid malloc(0)
Ok then. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
