On date Thursday 2011-05-26 15:35:34 +0200, Anton Khirnov encoded: > On Thu, 26 May 2011 13:45:06 +0200, Stefano Sabatini > <[email protected]> wrote: [...] > > > +#define OFFSET(x) offsetof(struct video_data, x) > > > +#define DEC AV_OPT_FLAG_DECODING_PARAM > > > static const AVOption options[] = { > > > { "standard", "", offsetof(struct video_data, standard), > > > FF_OPT_TYPE_STRING, {.str = "NTSC" }, 0, 0, AV_OPT_FLAG_DECODING_PARAM }, > > > { "channel", "", offsetof(struct video_data, channel), > > > FF_OPT_TYPE_INT, {.dbl = 0 }, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, > > > + { "video_size", "A string describing frame size, such as 640x480 or > > > hd720.", OFFSET(video_size), FF_OPT_TYPE_STRING, {.str = NULL}, 0, 0, DEC > > > }, > > > > Nit: maybe "size" with an "s" alias is better. > > > > Rest of the patch looks fine, same for the other similar patches. > > I don't think it's a good idea, we risk conflicts.
Yes indeed this is a problem that needs to be tackled. > Especially with current ffmpeg options parsing, where it's impossible > to differentiate between format/codec options, having options named > 'b' and 's' is very bad. User apps can provide aliases themselves > if they need them. What about: -codec_opts=size=qcif:r=film:... -format_opts=... -proto_opts=... ? -- Is knowledge knowable? If not, how do we know that? _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
