On 05/25/2011 05:37 PM, Alex Converse wrote: > On Wed, May 25, 2011 at 2:28 PM, Justin Ruggles > <[email protected]> wrote: >> >> uninitialized coefficients were being used to generate exponents, some of >> which actually ended up in the final stream, but those were just extra >> exponents that are not used by any decoder. >> --- >> libavcodec/ac3enc.c | 12 ++++++------ >> 1 files changed, 6 insertions(+), 6 deletions(-) >> > > OK to the content > > But the commit message should be rewritten. There is a legitimate > reason to have this. That reason is not fixing valgrind warnings.
How about: ac3enc: initialize all coefficients to zero. Uninitialized coefficients were being used to generate exponents, some of which actually ended up in the final stream. Even though, they were just extra exponents that are not used by any decoder, it is still better to have consistent output for testing. This also fixes valgrind errors. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
