Diego Biurrun <[email protected]> writes:

> The header is only really used in one place, so there is no need
> or sense in having a separate header.
> ---
>  libavcodec/aac_tablegen.h      |   11 ++++-------
>  libavcodec/aac_tablegen_decl.h |   36 ------------------------------------
>  libavcodec/aaccoder.c          |    1 +
>  libavcodec/aacdec.c            |    1 +
>  libavcodec/aacenc.c            |    2 +-
>  libavcodec/aactab.h            |    1 -
>  6 files changed, 7 insertions(+), 45 deletions(-)
>  delete mode 100644 libavcodec/aac_tablegen_decl.h

This isn't right.  Including aac_tablegen.h in more than one place
duplicates lots of tables, and probably doesn't work at all (only one
copy will be initialised).

I know I suggested something like this earlier.  I must have misread
something then.  I apologise for the inconvenience.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to