Hi, On Wed, Apr 27, 2011 at 6:56 PM, Diego Biurrun <[email protected]> wrote: > But only comments can keep us moving forwards. When I see a function > with 17 (!) parameters, I cannot help but make a remark. This does > not imply that I expect the poor soul that made a change to that > monster to singlehandedly refactor it.
I think the better thing is then to *not* make a comment during review, but rather note it for yourself and send a patch directly after. Even better, make a wiki page with all these comments lined up so people new to Libav have a place to start with trivial stuff. :-). Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
