On Mon, 18 Apr 2011 15:50:48 +0200, Stefano Sabatini 
<[email protected]> wrote:
> On date Monday 2011-04-18 11:24:01 +0200, Stefano Sabatini wrote:
> > On date Monday 2011-04-18 08:06:36 +0200, Anton Khirnov wrote:
> > [...]
> > > > diff --git a/libavformat/file.c b/libavformat/file.c
> > > > index 9d28a89..39f784c 100644
> > > > --- a/libavformat/file.c
> > > > +++ b/libavformat/file.c
> > > > @@ -60,9 +60,9 @@ static int file_open(URLContext *h, const char 
> > > > *filename, int flags)
> > > >  
> > > >      av_strstart(filename, "file:", &filename);
> > > >  
> > > > -    if (flags & AVIO_RDWR) {
> > > > +    if (flags & AVIO_FLAG_READ && flags & AVIO_FLAG_WRITE) {
> > > 
> > > flags & AVIO_FLAG_READ_WRITE ?
> > 
> > Yes (I see you already fixed it).
> 
> Damn no, I was right the first time:
> flags & AVIO_FLAG_READ_WRITE                      => read *or*  write is 
> enabled
> flags & AVIO_FLAG_READ && flags & AVIO_FLAG_WRITE => read *and* write is 
> enabled
> 
> easy to get confused though...

Right, fixed locally.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to