On 04/14/2011 06:23 PM, Stefano Sabatini wrote:
>> @@ -3309,6 +3326,7 @@ static void check_audio_video_sub_inputs(int
>> *has_video_ptr, int *has_audio_ptr,
>> case AVMEDIA_TYPE_DATA:
>> case AVMEDIA_TYPE_ATTACHMENT:
>> case AVMEDIA_TYPE_UNKNOWN:
>> + has_data = 1;
>
> Potentially wrong, as ATTACHMENT and UNKNOWN are tagged as data.
That is on purpose I want to be able to transparently copy all the
non-multimedia data, DATA and ATTACHMENT isn't different for this purpose.
>
>> + if(!data_stream_copy){
>
> Nit: K&R
>
>> + ffmpeg_exit(1);
>
> An error message may be useful
>
>> +
>> + if(data_codec_tag)
>
> Nit++: K&R
>
>> + else if (!strcmp(opt, "newdata")) new_data_stream(oc, file_idx);
>
> please keep vertical align
>
>> if (subtitle_disable) use_subtitle = 0;
>> + if (data_disable) use_data = 0;
>> +
>
> Nit+++: double empty line
I'll fix them soon, thanks for spotting all of them =)
lu
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
