akhiezer wrote:
From: Paul Rogers <[email protected]> Date: Thu, 04 May 2017 00:14:40 -0700For some uses I'd like my build scripts to not fail on tests that will be ignored anyhow. In automake-1.15 three FAILs seem to be common and due to flawed tests, notably check12{,-w}. I have added the following commands to my scripts to avert these FAILed tests: # check12 is known to fail, debian removes them so we will too rm -f t/check12{,-w}.sh && sed -e '/t\/check12.sh/d' -e '/t\/check12-w.log/d' -e 's/t\/check12-w.sh//' \ -i Makefile.in && sed '/t\/check12-w/d' -i t/testsuite-part.am && sed '/t\/check12/d' -i t/list-of-tests.mk && # remove another known failure sed -e '/t\/distcheck-no-prefix-or-srcdir-override.sh/d' -i Makefile.in &&It's better to let tests run, log what happens, then analyse the results, and do any actions as wanted/reqd: rather than suppress at source - which can be whac-a-mole, and at times opening security risks.
When I test a new package for the book, I always remove special code like this to see it they tests have been removed or fixed. I then make a decision whether to just document the problem or to add code to remove the problem.
I jsut went though this with vim and decided that a one line fix to remove the test was acceptable. For automake, IMO, it is too intrusive.
So the security issues are probably not an issue. It is a bit painful when upstream doesn't care about the tests enough to fix them or remove them.
-- Bruce -- http://lists.linuxfromscratch.org/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
