On Sun, Dec 20, 2015 at 02:55:22PM -0600, Bruce Dubbs wrote:
> Ken Moffat wrote:
> >On Sun, Dec 20, 2015 at 08:27:17PM +0000, Ken Moffat wrote:
> >>My script [ still with the trap for dash ] is
> >>attached as tools-check.sh.  It can be run at any time in chapter 5,
> >>subject to the open question about the name of the prefix for gcc
> >>pass 2.
> >>
> >[...]
> >>
> >>A version
> >>without my debug code is attached as check-no-tools-missed.sh.
> >>
> >This time, really attached.
> 
> I like the 2nd script.  It could be run any time in Chapter 5 but you should
> expect failures for any packages not yet installed.  What you should not get
> is something like:
> 
> OK
> OK
> ERROR
> OK
> ...
> 
I wrote it to run after the builder thinks he or she has installed
all the packages in chapter 5.  In that context, any failure _is_ an
error.

After all packages have been correctly built, the report mentions
the package as well as 'OK', e.g.

perl : OK
sed : OK
tar : OK
texinfo : OK
util-linux : OK
xz : OK

At the moment, if there is an error I report what I can (straight
files, package : /tools/path/filename does not exist), with a bit
more detail for symlinks [ trying to avoid broken symlinks ].

At the expense of not checking that a symlink is valid I could
change it all to report either 'OK' or 'present' for packages which
have been installed, or 'not installed' for those which are missing.
> 
> I'll note that one problem I've seen is that /tools is created, but not a
> symlink to /mnt/lfs/tools.  That's an error of course, but your script would
> not catch that.
> 
>   -- Bruce
> 

I've not seen that one.  You mean they put everything into /tools,
but it is a top-level directory on the host ?  Or something else ?

Also, what do you think about the 1st part, to tell people to read
the Host System Requirements if they are trying to use /bin/sh ->
dash ?
-- 
This email was written using 100% recycled letters.
-- 
http://lists.linuxfromscratch.org/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to