Am 22.04.2017 um 18:18 schrieb Bernhard Bliem: > Hi, > > I own a Panasonic Leica DG Summilux 25mm f/1.4 ASPH lens and I'm a > little confused: On the lensfun website's list of supported lenses, it > is listed, but it's not in the lensfun database according to > http://wilson.bronger.org/lensfun_coverage.html. Instead, the lensfun > database contains the "Leica D Summilux 25mm f/1.4 Asph." -- note it's > "D" and not "DG". Indeed there is a lens with this name for Four > Thirds, but the DG lens is for MFT. > > Is this a mistake in the lensfun database or is the DG really not > covered? Right now, assuming it's a typo, I'd have to manually select > the lens in Darktable for every photo, which is of course rather annoying. > > If the lens is indeed not covered, I'd of course be happy to help out > calibrating it.
Judging from the commit log it might be a regression when Sebastian Kraft tried to align the lensfun lens names to what an older Exiv2 version emitted, and that appears to have changed since. data/db/mil-panasonic.xml: > <lens> > <maker>Leica</maker> > <model>Leica D Summilux 25mm f/1.4 Asph.</model> > <mount>Micro 4/3 System</mount> > <cropfactor>2</cropfactor> > <aspect-ratio>4:3</aspect-ratio> > <calibration> > <!-- Taken with Olympus OMD E-M5 --> > <distortion model="ptlens" focal="25" a="-0.00305" b="-0.01088" > c="-0.00658"/> > <tca model="poly3" focal="25" br="-0.0000700" vr="1.0002675" > bb="0.0001262" vb="0.9998339"/> > </calibration> > </lens> And the OM-D E-M5 is ยต4/3. However the commit log reads: > commit 9379118f8ee900794532be3af921e3641ddd0b2f > Autor: Torsten Bronger <[email protected]> Sat Oct 12 > 22:23:28 2013 > Eintragender: Torsten Bronger <[email protected]> Thu Apr 3 > 13:24:38 2014 > Added Leica DG Summilux 25/f1.4 and Samyang 8mm f/2.8 UMC Fish-eye. The offending commit appears to be: > commit 1314bee93b560cb7006b1e7bd93face106bd9345 > Author: Sebastian Kraft <[email protected]> > Date: Sun Mar 27 13:33:03 2016 +0200 > Fix Bug #51: Leica DG Summilux database names do not match exiv2 names > diff --git a/data/db/mil-panasonic.xml b/data/db/mil-panasonic.xml > index 69343fe..ee4cb0f 100644 > --- a/data/db/mil-panasonic.xml > +++ b/data/db/mil-panasonic.xml > @@ -1072,7 +1072,7 @@ > > <lens> > <maker>Leica</maker> > - <model>Leica DG Summilux 25mm f/1.4 Asph.</model> > + <model>Leica D Summilux 25mm F1.4 Asph.</model> > <mount>Micro 4/3 System</mount> > <cropfactor>2.0</cropfactor> > <aspect-ratio>4:3</aspect-ratio> > @@ -1312,7 +1312,7 @@ > > <lens> > <maker>Leica</maker> > - <model>Leica DG Summilux 15mm f/1.7</model> > + <model>Leica DG Summilux 15mm F1.7 Asph.</model> > <mount>Micro 4/3 System</mount> > <cropfactor>2</cropfactor> > <aspect-ratio>4:3</aspect-ratio>... which may have aligned the name in lensfun to what Exiv2 0.23 or older used to provide. This is what I see in Exiv2's SVN repo as of r4758: > src/olympusmn.cpp:1355: { { 2, 2, 0 }, "Leica D Summilux 25mm > F1.4 Asph." }, > src/olympusmn.cpp:1369: { { 2, 18, 16 }, "Leica DG Summilux 25mm > F1.4 Asph." }, > src/olympusmn.cpp:1379: { { 2, 34, 16 }, "Leica DG Summilux 15mm > F1.7 Asph." }, > src/olympusmn.cpp:1387: { { 3, 2, 0 }, "Leica D Summilux 25mm > F1.4 Asph." }, And the DG entry was added to Exiv2 with changeset 2975, and the next tag after that I find is Exiv2 0.23.1. > ------------------------------------------------------------------------ > r2975 | robinwmills | 2013-01-16 03:15:19 +0100 (Wed, 16 Jan 2013) | 1 line > Changed paths: > M /trunk/src/olympusmn.cpp > Fix: #879. Olympus Thank you Neils for the patch. > ------------------------------------------------------------------------ > $ LC_ALL=C svn log -vr2975 --diff | grep Summilux > - { { 2, 2, 0 }, N_("Leica D Summilux 25mm F1.4 Asph.") > }, > - { { 3, 2, 0 }, N_("Leica D Summilux 25mm F1.4 Asph.") > }, > + { { 2, 2, 0 }, N_("Leica D Summilux 25mm F1.4 Asph.") > }, > + { { 2, 18, 16 }, N_("Leica DG Summilux 25mm F1.4 Asph.") > }, > + { { 3, 2, 0 }, N_("Leica D Summilux 25mm F1.4 Asph.") > }, It appears that Sebastian's commit mentioned above is out of synch and causes the regression you are seeing and the first hunk of it should be reverted at least WRT the DG Summilux. The second hunk changes this and might be correct as it stands, someone else needs to check that. That concludes my history research, let someone else fix the entry.
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Lensfun-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lensfun-users
