[
https://issues.apache.org/jira/browse/LABS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688735#action_12688735
]
Simone Gianni commented on LABS-321:
------------------------------------
There were many problems going on here.
The first one is that URL rewriting does not work when hidden methods come into
play, unless they refer to another do method. This is okay up to some extent :
the hidden methods are there to avoid being referred from outside, but if they
return a producer that contains link to perfectly accessible do methods,
shouldn't they be there? Inline administration was using a hidden method to
produce the menu, had to convert it to a plain do method, but I raised the bug
LABS-322 for this.
The second one was that URL rewriting stream was not in sync with producers. To
say it better, it was in sync with produce(Stream) but not with
produce(Writer). That part has been rewritten, and right now both produce
methods must be considered in some parts of the system.
The third one was a stupid bug in the URL rewriting stream current url stack.
> [inlineadministration] Incorrect URL generated for admin popups
> ---------------------------------------------------------------
>
> Key: LABS-321
> URL: https://issues.apache.org/jira/browse/LABS-321
> Project: Labs
> Issue Type: Bug
> Components: Magma
> Affects Versions: Current
> Reporter: Simone Gianni
> Assignee: Simone Gianni
> Fix For: Current
>
>
> Instead of /administration/etc/etc/etc the current element context url is
> used, like for example /content/etc/etc . This is a conseguence of the
> refactoring of the URL system in the context, but it's strange because it
> should go thru root.
> Currently there are test cases where using root().handleThis().doThat()
> returns the correct URL, while inline administration uses
> RootWebHandler.getInstance().handleThis(), anyway it should be the call to
> handleThis() that, being executed on RootWebHandler, resets the url system.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
