I don't think the changes in a69990c fix the tab out saving the category. I'm sure I built after that was added, and experienced the issue yesterday a few times while testing.
On Tue, Jan 3, 2023 at 9:33 AM Jeremy Whiting <jeremypwhit...@gmail.com> wrote: > > > On Tue, Jan 3, 2023 at 12:25 AM Thomas Baumgart via KMyMoney-devel < > kmymoney-devel@kde.org> wrote: > >> >> On Dienstag, 3. Januar 2023 05:15:14 CET Jeremy Whiting via >> KMyMoney-devel wrote: >> >> > On Mon, Jan 2, 2023 at 4:56 PM Jack <ostrof...@users.sourceforge.net> >> wrote: >> > >> > > On 2023.01.02 18:31, Jeremy Whiting wrote: >> > > > 2 other issues I keep hitting that I'm trying to find the cause of >> to >> > > > fix: >> > > > >> > > > 1) Sometimes when I enter a category, it gets forgotten when I click >> > > > the >> > > > Enter button. It's not always, but when entering a new transaction, >> > > > typing >> > > > part of a Category, selecting it from the completion list, then tab >> > > > until >> > > > Enter is focused and hitting space/enter to click it. Or clicking >> the >> > > > button. It seems to happen more often when the transaction is left >> Not >> > > > reconciled. If it's cleared it usually remembers it. >> > > I'm pretty sure this has been reported before. When you select the >> > > Category from the dropdown, pay attention to how you actually select >> > > the value - clicking on it, hitting Enter, or Tabbing to the next >> > > field. I vaguely recall only one of those lost the selection. I've >> > > probably seen it myself, and just re-selected and moved on, instead of >> > > tracking down the cause. >> > > >> > >> > Yep, if I hit enter, then tab it keeps, it. If I just hit tab to move to >> > the next field once it's the only remaining choice, it forgets. Ok >> digging >> > in to see what's causing the difference. Thanks for pointing that out. >> >> During a recent bug tracking issue, I noticed that the activated() signal >> of >> a combobox is emitted *after* the focusOut event is processed. See commit >> a69990c76bf. This could also apply here. Will take a look. >> > > Yeah, maybe that helps. I'll watch for reoccurrence. > >> >> >> > > > 2) Changing the date with the keyboard on a new transaction. Up >> arrow >> > > > goes >> > > > up to a previous transaction instead of increasing the date. typing >> > > > numbers >> > > > does nothing somehow. Only way I've found so far to change the date >> > > > on a >> > > > new transaction is to click it and select a date from the month >> view. >> > > Are you sure you actually have the date field selected? In my >> > > experience, when you edit a transaction, no field is actually >> selected, >> > > even though one part of the date field is highlighted. It looks like >> > > it is selected, but it isn't. Hit Tab and now one part of the date >> > > field is selected. >> > > >> > >> > Yep, date just looks selected, but the hidden "Account" combo box is >> likely >> > at first. Thanks, works much better once I tab into the date field >> itself. >> > hmm. >> >> The account combo box is used when editing a schedule. So it cannot simply >> be removed. >> >> @Jeremy: did you modify the tab order in any way or due you use the >> pristine >> version provided by the application? >> > > I see. We may want to adjust the tab order then inside setShowAccountCombo > instead, to remove or add the accountCombo to the front of the order > depending if it's visible or not. > > No, I didn't use a modified build, have been testing master branch for the > past couple of weeks. > >> >> >> -- >> >> Regards >> >> Thomas Baumgart >> >> ------------------------------------------------------------- >> Contrary to popular belief, Unix is user friendly. It just happens to >> be very selective about who it decides to make friends with. -- unknown >> ------------------------------------------------------------- >> >
