----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130035/#review103329 -----------------------------------------------------------
Ship it! Ship It! - Thomas Baumgart On März 19, 2017, 11:15 nachm., Mark Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130035/ > ----------------------------------------------------------- > > (Updated März 19, 2017, 11:15 nachm.) > > > Review request for KMymoney. > > > Bugs: 377818 > http://bugs.kde.org/show_bug.cgi?id=377818 > > > Repository: kmymoney > > > Description > ------- > > Fix bug 377818 - QIF import does not support ContribX and WithdrwX > transactions > > > Diffs > ----- > > kmymoney/converter/mymoneyqifreader.cpp bff43c7 > > Diff: https://git.reviewboard.kde.org/r/130035/diff/ > > > Testing > ------- > > Testing done with various QIF files exported from Quicken Home and Business > 2014 (Canada version). > > Note: The "P" field (normally Payee) is labelled "Description" in the Quicken > UI for these transaction types. It did not seem appropriate to populate the > Payee with this Description text so it is prepended to the "Memo" field to > avoid data loss. This also impacts the XIn/XOut transaction types. Prior to > this fix the Description text was being discarded for the XIn/XOut > transactions. > > > File Attachments > ---------------- > > mymoneyqifreader.cpp.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/19/41d720b9-2a1c-45b8-850f-314e9e44afc8__mymoneyqifreader.cpp.diff > mymoneyqifreader.cpp.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/19/d77dab6f-d62b-48a8-9e00-f8452a89f69b__mymoneyqifreader.cpp.diff > > > Thanks, > > Mark Jones > >