----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129116/#review103237 -----------------------------------------------------------
kmymoney/kmymoney.cpp (line 2192) <https://git.reviewboard.kde.org/r/129116/#comment68688> I'd use if ((dlg->exec() == QDialog::Accepted) && dlg) here to make sure that dlg is still pointing to an object and has not been distroyed in the meantime. - Thomas Baumgart On Mai 22, 2017, 9:04 vorm., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129116/ > ----------------------------------------------------------- > > (Updated Mai 22, 2017, 9:04 vorm.) > > > Review request for KMymoney and Thomas Baumgart. > > > Bugs: 370224 > http://bugs.kde.org/show_bug.cgi?id=370224 > > > Repository: kmymoney > > > Description > ------- > > Before exporting a dialog is now shown with which users can fill > in title, short and long description. > > BUG:370224 > > > Diffs > ----- > > kmymoney/converter/mymoneytemplate.h 888178b > kmymoney/converter/mymoneytemplate.cpp b90adb0 > kmymoney/dialogs/CMakeLists.txt 0daa6f6 > kmymoney/kmymoney.cpp fc12a36 > > Diff: https://git.reviewboard.kde.org/r/129116/diff/ > > > Testing > ------- > > tested on 4.8 branch > > > Thanks, > > Ralf Habacker > >
