----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129862/ -----------------------------------------------------------
Review request for KMymoney. Repository: kmymoney Description ------- KMM icons look properly only if oxygen icon theme is set globally. Tango and hicolor themes aren't used at all. This patch introduces settings page which allows setting icon theme (system, oxygen or Tango) only for KMM and independently from global setting. It also makes use of hicolor and Tango theme. Look of KMM is more complete on icon themes different from oxygen. DesktopIcon function has been replaced, because it hadn't respect QIcon::setThemeName. Tango icons names has been adjusted to hicolor names and are used as fallback icons to oxygen names. Diffs ----- kmymoney/dialogs/settings/CMakeLists.txt 72d4e1a kmymoney/dialogs/settings/ksettingsicons.h PRE-CREATION kmymoney/dialogs/settings/ksettingsicons.cpp PRE-CREATION kmymoney/dialogs/settings/ksettingsiconsdecl.ui PRE-CREATION kmymoney/dialogs/settings/ksettingskmymoney.cpp 05759f8 kmymoney/icons/CMakeLists.txt 3af9f4d kmymoney/icons/Tango/128x128/actions/128-actions-account-types_asset.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_cash.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_checking.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_closed.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_credit-card.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_expense.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_income.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_investments.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_liability.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_loan.png kmymoney/icons/Tango/128x128/actions/128-actions-account-types_savings.png kmymoney/icons/Tango/128x128/actions/128-actions-account_add.png kmymoney/icons/Tango/128x128/actions/128-actions-forcast.png kmymoney/icons/Tango/128x128/actions/128-actions-institution_add.png kmymoney/icons/Tango/128x128/actions/128-actions-institutions.png kmymoney/icons/Tango/128x128/actions/128-actions-investments.png kmymoney/icons/Tango/128x128/actions/128-actions-onlinebanking.png kmymoney/icons/Tango/128x128/actions/128-actions-transaction_find.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_asset.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_cash.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_checking.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_closed.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_credit-card.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_expense.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_income.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_investments.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_liability.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_loan.png kmymoney/icons/Tango/16x16/actions/16-actions-account-types_savings.png kmymoney/icons/Tango/16x16/actions/16-actions-account_add.png kmymoney/icons/Tango/16x16/actions/16-actions-close_window.png kmymoney/icons/Tango/16x16/actions/16-actions-forcast.png kmymoney/icons/Tango/16x16/actions/16-actions-hide_categories.png kmymoney/icons/Tango/16x16/actions/16-actions-hide_reconciled.png kmymoney/icons/Tango/16x16/actions/16-actions-institution_add.png kmymoney/icons/Tango/16x16/actions/16-actions-institutions.png kmymoney/icons/Tango/16x16/actions/16-actions-investments.png kmymoney/icons/Tango/16x16/actions/16-actions-onlinebanking.png kmymoney/icons/Tango/16x16/actions/16-actions-personal_data.png kmymoney/icons/Tango/16x16/actions/16-actions-split_transaction.png kmymoney/icons/Tango/16x16/actions/16-actions-transaction_find.png kmymoney/icons/Tango/16x16/actions/16-actions-view_info.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_asset.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_cash.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_checking.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_closed.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_credit-card.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_expense.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_income.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_investments.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_liability.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_loan.png kmymoney/icons/Tango/22x22/actions/22-actions-account-types_savings.png kmymoney/icons/Tango/22x22/actions/22-actions-account_add.png kmymoney/icons/Tango/22x22/actions/22-actions-close_window.png kmymoney/icons/Tango/22x22/actions/22-actions-forcast.png kmymoney/icons/Tango/22x22/actions/22-actions-hide_categories.png kmymoney/icons/Tango/22x22/actions/22-actions-hide_reconciled.png kmymoney/icons/Tango/22x22/actions/22-actions-institution_add.png kmymoney/icons/Tango/22x22/actions/22-actions-institutions.png kmymoney/icons/Tango/22x22/actions/22-actions-investments.png kmymoney/icons/Tango/22x22/actions/22-actions-onlinebanking.png kmymoney/icons/Tango/22x22/actions/22-actions-personal_data.png kmymoney/icons/Tango/22x22/actions/22-actions-transaction_find.png kmymoney/icons/Tango/22x22/actions/22-actions-view_info.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_asset.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_cash.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_checking.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_closed.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_credit-card.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_expense.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_income.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_investments.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_liability.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_loan.png kmymoney/icons/Tango/32x32/actions/32-actions-account-types_savings.png kmymoney/icons/Tango/32x32/actions/32-actions-account_add.png kmymoney/icons/Tango/32x32/actions/32-actions-forcast.png kmymoney/icons/Tango/32x32/actions/32-actions-institution_add.png kmymoney/icons/Tango/32x32/actions/32-actions-institutions.png kmymoney/icons/Tango/32x32/actions/32-actions-investments.png kmymoney/icons/Tango/32x32/actions/32-actions-onlinebanking.png kmymoney/icons/Tango/32x32/actions/32-actions-transaction_find.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_asset.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_cash.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_checking.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_closed.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_credit-card.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_expense.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_income.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_investments.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_liability.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_loan.png kmymoney/icons/Tango/48x48/actions/48-actions-account-types_savings.png kmymoney/icons/Tango/48x48/actions/48-actions-account_add.png kmymoney/icons/Tango/48x48/actions/48-actions-forcast.png kmymoney/icons/Tango/48x48/actions/48-actions-institution_add.png kmymoney/icons/Tango/48x48/actions/48-actions-institutions.png kmymoney/icons/Tango/48x48/actions/48-actions-investments.png kmymoney/icons/Tango/48x48/actions/48-actions-onlinebanking.png kmymoney/icons/Tango/48x48/actions/48-actions-transaction_find.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_asset.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_cash.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_checking.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_closed.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_credit-card.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_expense.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_income.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_investments.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_liability.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_loan.png kmymoney/icons/Tango/64x64/actions/64-actions-account-types_savings.png kmymoney/icons/Tango/64x64/actions/64-actions-account_add.png kmymoney/icons/Tango/64x64/actions/64-actions-forcast.png kmymoney/icons/Tango/64x64/actions/64-actions-institution_add.png kmymoney/icons/Tango/64x64/actions/64-actions-institutions.png kmymoney/icons/Tango/64x64/actions/64-actions-investments.png kmymoney/icons/Tango/64x64/actions/64-actions-onlinebanking.png kmymoney/icons/Tango/64x64/actions/64-actions-transaction_find.png kmymoney/kmymoney.cpp 550de35 kmymoney/kmymoney.kcfg 4d503f3 kmymoney/kmymoneyutils.h ab3a5d9 kmymoney/kmymoneyutils.cpp a8d0992 kmymoney/models/accountsmodel.cpp b395e16 kmymoney/mymoney/mymoneyaccount.cpp a9cf7e3 kmymoney/mymoney/mymoneyinstitution.cpp 344bfd0 kmymoney/views/kforecastview.cpp 404a28d kmymoney/views/kmymoneyview.cpp 8301c66 kmymoney/views/kreportsview.cpp 8d05455 kmymoney/views/kscheduledview.cpp 827ea44 kmymoney/widgets/kmymoneyaccountselector.cpp eaccb22 Diff: https://git.reviewboard.kde.org/r/129862/diff/ Testing ------- Tested KMM with Tango, oxygen and locally installed icon theme. Thanks, Łukasz Wojniłowicz
